CyrusKabir• 1,885
@CyrusKabir
Posted
hello my friend ♥ it's good at all but here some little problems :
- it's better to don't have empty tag in html and it's better have image in this case with <img> tag instead background properties
- and it's cleaner and easyer to have padding in main content rather than a lot of margin for spacing around you know what i mean it's easyer with parent padding rather than margin to every element and at all it's good,clean but make it better and go ahead for more challenges ♥
0
Claire Tregunna• 65
@c-tregunna
Posted
@CyrusKabir Thank you for the feedback.
I did originally have the image in the HTML, however couldn't get the color overlay set, but I have had a think about how to achieve this now.
Yep, totally agree about the margins.....I don't know what I did those and not padding.
1
