Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSC FLEX

@Mimieveshofuo

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would like feedback on this job. And advice on how it could be done better

Community feedback

@MikeBish13

Posted

Hey, great job on the project.

One major thing I've noticed:

  • When you get to around 780px screen size, the end of the content box gets cut off. This is because you have a container with a width of 70% and overflow: hidden set, so when the content is too big for the container it disappears. You could solve this by either making the breakpoint of your media query larger, or perhaps explore another way of centering your content box without the need for a container -- flexbox could be a neat way of doing this.

On a more general note, you have exactly the same styles repeated for each of the three sections in your container. You could maybe consider applying a single class to each of the three sections, eg class="car-container", and that would drastically reduce the amount of code that you have to write.

Hope that helps!

1

@Mimieveshofuo

Posted

@MikeBish13 Thanks for the feedback.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord