Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML + CSS

Zdravko 350

@Zdravko93

Desktop design screenshot for the Order summary component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Travolgi 🍕 31,460

@denielden

Posted

Hi Zdravko, I took some time to look at your solution and you did a great job!

Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image
  • Centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid, so remove margin, position, top, left and transform properties from .container class because with flex they are superfluous
  • add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

For fix the top image in the background just put more specific background properties to the body:

background: url("../img/pattern-background-desktop.svg") no-repeat top center;
background-size: contain;
background-color: #e0e8ff;

Overall you did well :)

Hope this help and happy coding!

Marked as helpful

1

Zdravko 350

@Zdravko93

Posted

@denielden Thank you very much! I appreciate you taking time to inspect my code, and giving it a nice, neat feedback. I will do as you advised. Thanks again!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord