Account Deleted
Hello quocbao19982009,
Congratulations on completing this challenge 🥳🎉
You solution looks good and very close to the actual design.
Few suggestions I have here
• use universal selector instead of putting all tags in one place(the universal selector provided by CSS helps in choosing any elements within the HTML page)
*{
margin: 0;
padding:0;
}
• Use HTML heading tag for headings.(Heading tags are indicators used in HTML to help structure your webpage from an SEO point of view, as well as helping Google to read your piece of content )(h1-h6 )
• Checkout this link for semantic HTML tags (https://www.w3schools.com/html/html5_semantic_elements.asp)
• use fr(fractional unit) when setting up the grid.
• Checkout this link (https://www.geeksforgeeks.org/css-grid-layout-the-fr-unit/)
• For your second question ( I don't have the exact answer) ,but when it comes to 2k screen (as far as I know there is no specific rule to follow)
Great work here 👍
Have fun coding 💻
Marked as helpful
@quocbao19982009
Posted
@Nik-web12 Thanks! Really appreciate the feedback!
This helps me gain some new knowledge, I will definitely take your feedback into my practices.
Happy Coding!