Hi @fullstackdeveloper3 👋🏻
I have some suggestions on how to fix the accessibility and some other minor issues.
- In your markup <div class="card">...</div> should be <main class="card">...</main> and <div class="attribution">...</div>. These will fix all of your accessibility issues. Don't forget to generate a new repot once you fix the issues.
- For
<img src="images/icon-music.svg" alt="icon">, I'd suggest addingaria-hidden="true"because this image is for decorative purposes only. You can read more about aria-hidden here - Also, I'd suggest changing
widthof.containerto40%and addpadding: 40px;to.background. This will give some whitespace to your content, which will make your website look closer to the design.
I hope this was helpful 👨🏻💻 you did a great job for the first project, keep practicing. Cheers 👾
Marked as helpful
1
abdullah• 60
@fullstackdeveloper3
Posted
@kens-visuals thanks bro, you helped my a lot.
0
@fullstackdeveloper3 no worries bro 👌🏻
P. S. I see you submitted again, but next time just update whatever you need to update and push it to your repo in GitHub. You can also take a new screenshot if you want the changes to be seen here too. However, you don't need to re-submit the project after every correction. But it's just my opinion 🙃
Marked as helpful
1
abdullah• 60
@fullstackdeveloper3
Posted
@kens-visuals oh, thanks bro 😂😂😂😂
0
