@YariMorcus
Posted
Hi @chiozoadiro,
First of all, congratulations on completing your first challenge! I took a look at your design, and it looks pretty good.
However, I do have some feedback I want to share with you so that you can become even a better developer than you already are.
My feedback is divided into sections to make it more clear.
Mobile
- Your component should be a little wider. If you do this, your text will align better according to the design both on mobile as desktop. Besides that, the width of your component will be both the same on mobile and desktop (you do not have to adjust anything specific for desktop).
Tips
- You can center any component horizontally and vertically by doing the following (assuming that the page only contains a component). Place
min-height: 100vh;
,display: grid;
andplace-items: center;
on<body>
. If you do this, you do need to remove the div with idforest-ext-shadow-host
(just as a sidenote: I do not see any CSS attached to this id, so I think you might forgot to remove it?). - Always place the
width
andheight
attributes on<img>
, and use the pixel values of the width and height of your image (the size you are going to use). This gives as a result that your page will load faster, the page won't jump when suddenly an image loads in (very frustrating for users), and your page will act smoother. - I saw you have been using rem values for your widths, margins, paddings and font-sizes, and used
font-size: 62.5%
on<html>
. If you want to make it easier for yourself to calculate your em and rem values, then you should replace62.5%
with10px
. If you want to use em and rem values, the only thing you have to do isfont-size (or width size) / 10 = your em/rem value
. This will make it a lot easier for you instead of using a percentage on your root element (<html>).
Things you did good (may also be said)
- Even though the width of your component should have been a little wider, you still did a great job on making it look as close as possible to the design.
- You placed the specific part of your content within
<title>
upfront (I hope that I am saying this correctly haha). - You implemented BEM correctly.
- You have been using the color models consistently (HSL in this case).
I hope you can do something with the feedback and tips I gave you. If you have any more questions, feel free to ask me.
If I made a mistake somewhere in this post, feel free to correct me and keep building awesome things π
Marked as helpful
@ejikemechiozoadiro
Posted
@YariMorcus Thanks a lot