Skip to content
Submitted over 2 years ago

HTML, CSS

Muhamed•50
@Madmohammed22
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hi there, I’m Mohamed and this is my solution for this challenge. 🤝

Any feedback on how I can improve the code are welcome!

Code

Please log in to post a comment

Log in

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Greetings, Muhamed! 👋

    Congratulations on completing your first Frontend Mentor challenge! 🎉 Good job on this challenge! 👏

    A few things I suggest are,

    • Avoiding using px for setting the value of font-size in your styles. Instead, use a responsive unit such as em or rem so that users will be able to change the size of the text in your site by changing the default font-size of their browser. It might also be worth setting the values for other properties such as margin or padding in those units so that your entire site will scale with the user's chosen default font-size. If you'd like to learn more about those units in CSS and how all of this works, check out this helpful video on the topic.
    • Adding a favicon to the site. There should be one in the starter files for this challenge that you can use. 😉

    Hope you find this helpful. 😊

    Keep coding (and happy coding, too)! 😁

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord