Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML CSS

Tesla_Ambassadorβ€’ 2,980

@tesla-ambassador

Desktop design screenshot for the Single price grid component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey everyone, I am open to any feedback. Please let me know where I can improve on my solution.

Community feedback

Agata Liberskaβ€’ 4,015

@AgataLiberska

Posted

Hi @tesla-ambassador, it looks great! I noticed two things: not sure whether <article> is the best choice for the sections of your card. All three parts form one whole component, and an <article> is something that makes sense on its own and can be distributed independently. I would probably just use divs here, but there may be a better option. The second thing is a tiny detail and I don't know this design, so sorry if that's what it was supposed to look like - but all text is centered in column layout, except for the price - was that intentional?

Hope this helps :)

2

Tesla_Ambassadorβ€’ 2,980

@tesla-ambassador

Posted

@AgataLiberska Thanks for the feedback. I had used divs in the first place but now that I think about it, I agree that I should have stuck with them and the text centered in the column layout except for the price was intentional. I was experimenting hahaha... ( They should add emojis for windows users)

1
P
ApplePieGiraffeβ€’ 30,545

@ApplePieGiraffe

Posted

Hey, TeslaAmbassador! πŸ‘‹

Sorry, it took me a while to give you feedback for this challenge. πŸ™ƒ But good job on this one, of course! πŸ‘

I think it would be better if you gave the card component a fixed width (rather than a width dependant upon the width of the viewport) and then simply changed the width using a media query when the width of the screen becomes very small. This will make the dimensions and design of the card component more consistent across screen sizes and make it easier to work with.

And rather than add margin-top: 10% to the body, add min-height: 100vh. That'll ensure that the body is always at least as high as the viewport itself and eliminate the need to add margin-top: 10% to create some space between the top of the page and the card component. πŸ˜‰

Keep coding (and happy coding, too)! 😁

1

Tesla_Ambassadorβ€’ 2,980

@tesla-ambassador

Posted

@ApplePieGiraffe Thanks for the feedback my good brother. I will improve on my solution based on the advice you have given to me. I didn't notice that I had given it a width based on that of the view port but sticking to a fixed width sounds like a better idea, I will get to that right away!

2
P
ApplePieGiraffeβ€’ 30,545

@ApplePieGiraffe

Posted

@tesla-ambassador

NP! Keep coding! πŸ‘

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord