@Jawha3
Posted
Hello Kirin, I'm no expert at all but what I've been taught and trying to do more of, is use more html sematics and not so many div-tags.
Also just want to point out that it seems we are not able to actually see the website, only the code - something must have went wrong when you uploaded the solution :)
EDIT: Oh and also I just noticed you use "px" in your css - that I have been told is best to avoid in most cases and instead use "rem" and "em" where approbiate.
Marked as helpful
@Kirin02
Posted
@Jawha3 Thank you, that was helpfull also, for the live page i uploaded it on github and activated Main branch and root file but it still not working i don't understand why
@Jawha3
Posted
@Kirin02 I wish I could help you with that, but I am only just now about to start a challenge - so I have no knowledge on how to upload solutions yet :3
