Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

html, css

Nikola•80
@nsokolovac
A solution to the Single price grid component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hello Frontend Mentor team,

I'm graduated engineer of IT from 2016. but I never try web developing by myself before. This is one of my first projects to test my skills. If you have any suggestions/recommendation where I need to pay more attention, or on what to focus in future (if it is possible to recognize right now), please give me feedback. After few successfully completed challenges in html+css, I will continue to upgrade my skills on javascript, than other languages.

Thanks in advance, Best regards, Nikola Sokolovac

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Cường•885
    @docuong0912
    Posted over 4 years ago

    Greeting Nikola, In my opinion, these are things that you should take into consideration:

    1. Instead of using p1,p2,p3...,you could use Descendant Selector for example: div p { } to style all the p tag inside div or .class p {} to style p inside that class. You can read more here : w3schools.com/css/css_combinators.asp

    2. I'm not quite understand what purpose of this line div style="display: flex;", maybe you want it to display inline, you could set a class name for that div and then use Descendant Selector, example: .class p { display : inline } instead

    3. I see that there's many p tags have same attributes, instead of writing for each tag, just write for one p tag, and it will apply all the p tag in the page, this basic technique can use for all tag in html file, you can read more about it here: https://www.w3schools.com/css/css_selectors.asp

    4. Instead of ".button" class, button tag might be a better option you can check out more tags here : https://www.w3schools.com/tags/default.asp, similarly .header -> header tag

    5. You should be aware when using inline styling because according to Cascading Order, the inline style takes the highest priority, which mean it's useless if you want to change some attributes in external stylesheet for example in your code :div class="whyUs" style="margin-bottom: 30px;> if you want to change margin-bottom : 100px in .css file, it will not be applied you can read more about Casading Order here : https://developer.mozilla.org/en-US/docs/Learn/CSS/Building_blocks/Cascade_and_inheritance or example here : https://www.w3schools.com/css/tryit.asp?filename=trycss_howto_cascade

    6. Font-size and font-family should in body tag, if there's just 1 font so you don't need to rewrite multiple times

    That's all, these are just my recommendation to optimize some part of your code, you didn't do anything wrong, these advice are based on my experience, i'm not judging anything,okay :))

    In general, if this is your very first project, you are doing extremely great, you even know responsive design, better than me back then :)), good job

    Hope this help, Happy coding !

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub