Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML CSS

@prajwal18

Desktop design screenshot for the Stats preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Can someone review my work and give feedback, best practices, how you would do certain aspects differently. Any feedback would be highly appreciated.

Community feedback

darryncodes 6,430

@darryncodes

Posted

Hi Prajwal,

Not much to say but really well done, you've nailed it!

  • I think you may have missed this. change <div class="attribution"> to <footer class="attribution"> semantic html info
  • I noticed you had some nested selectors, have you considered using BEM methodology. Some people hate it, some love it, but i think it can be really useful when building a larger project and using scss
  • BEM (Block, Element, Modifier) is a component-based approach to web development. The idea behind it is to divide the user interface into independent blocks. This makes interface development easy and fast even with a complex UI, and it allows reuse of existing code without copying and pasting.

All the best!

Marked as helpful

1

@prajwal18

Posted

@darryncodes Thank you, that was very insightful. I'll be sure to make those changes.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord