HTML, CSS

Community feedback

• 

  Ecem Gokdogan•9,380

  @ecemgo

  Posted about 2 years ago

  Some recommendations regarding your code that could be of interest to you.

  HTML

  In order to fix the accessibility issues:

  • I couldn't view your GitHub repository, you've typed the home page of GitHub. Anyway, I'll try to give some recommendations.
  • You need to replace <div class="container"> with the <main class="container"> tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly.
  • Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you should use one <h1> element in the <main> tag.

  CSS

  • If you want, you can use the recommended color for the background but it's up to you whether you use or not :

  body {
    background-color: hsl(212, 45%, 89%);
  }
  

  Hope I am helpful. :)

  12

  Marked as helpful
• 

  Manish Patel•740

  @savvystrider

  Posted about 2 years ago

  Looks awesome! The main text is a bit hard to read against the background (not enough contrast), so I'd recommend using a darker color to make it stand out.

  11