Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS & JavaScript

@WackLantern

Desktop design screenshot for the FAQ accordion card coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Thank you for taking the time to view my code. This is my first time building a project with JavaScript. It was extremely difficult, but I managed to figure it out. I will appreciate any and all feedback.

Community feedback

hardy• 3,660

@hardy333

Posted

Hey, nice solution but you have too many accessibility and html validation isses. In order to fix them:

  • Use semantic html elements, for example for .card element use <main></main> element instead of <div></div>
  • Use h2 tag instead of h3 this will fix one issue.
  • Use alt property for all the images
1
Fidel Lim• 2,775

@fidellim

Posted

Hi William,

Great work on this project especially you have integrated JavaScript! Just a suggestion, you might want to have a look at linear-gradient. So that you can change the background color into what the design looks like.

Hope it helps :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord