Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 4 years ago

HTML, CSS and JavaScript

Ahmed Sameh•60
@Ahmed0107
A solution to the Intro component with sign-up form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Can you rate this work, please?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Dave•5,295
    @dwhenson
    Posted almost 4 years ago

    Hi @Ahmed0107 nice job here. 🙌

    With regards the mobile layout, I would suggest setting the height of the body element as min-height: 100vh and then moving some of the styles from your first wrapper to the body (such as the background image/color etc).

    If you then, add the flex settings you have on the wrapper to the body this should then position the wrapper, and everything inside it, at the center of the viewport at all resolutions. At the moment it's not working on mobile views.

    You can probably then do away with the container inside the wrapper and just set a max-width on the wrapper div. Hopefully this should keep things centered. I'd avoid specifying heights on anything if possible, and only a min-height if you really have to.

    Getting things laid out in the center of the screen is tricky, but as it will come up again and again in these challenges it's worth spending a bit of time to find an approach that works for you.

    Cheers 👋

    Dave

    Marked as helpful
  • Conrad•930
    @ConradMcGrifter
    Posted almost 4 years ago

    its pretty decent. I would rate it 7.5/10

    • I think you need to fix the layout on mobile
    • on desktop at larger resolutions your design is stretching so try putting a max width on your div container
    • I think you need to validate the password better because currently you can enter just 1 character and it will accept it. maybe put a length requirement
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub