Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 4 years ago

HTML, CSS and Javascript

Lauren Stroud•95
@CommanderMeow
A solution to the Blogr landing page challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Still very much a beginner when it comes to front end and looking for any suggestions that can help me improve. This was the first Front End Mentor project I did and it is very ID heavy, I realise that using ID's should be reserved for special cases and that Classes would be a much prefered way of selecting elements but any thoughts on how I can improve this would be helpful.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Dave•5,295
    @dwhenson
    Posted about 4 years ago

    Hi @CommanderMeow great job on this one - I really struggled with this one, especially placing all those images in the right places, but you seem to have done that really well! 🙌

    Here's a few points to think about:

    1. For the HTML, I would suggest using some of the elements that were brought in in HTML5. This would include header, nav, main, footer etc. At the minute your divs with id's are working but this would be better for people using assistive tech to use your site. This will solve most of the accessibility issues highlighted in your report too.

    2. On large screens your page becomes very spread out. I would consider putting some constraints on your content to prevent this. There are a few different ways to achieve this I like to add the following to my body element:

    .center-content {
    	display: grid;
    	grid-template-columns: minmax(1rem, 1fr) minmax(375px, 1440px) minmax(1rem, 1fr);
    }
    
    	.center-content > * {
    		grid-column: 2;
    	}
    

    This puts all the direct children of the body in the center column, that has a min-width of 375px and a max of 1440px. The outside columns provide a bit of spacing.

    You'll find in this challenge that this causes a number of other issues though - all solvable, but a bit hectic sometimes.

    I hope this helps. I've tried to focus on things that will help you in future challenges rather than picking up details. Really good job though - keep up the good work!! 👍

    Cheers 👋

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub