Skip to content
Submitted over 2 years ago

HTML, CSS, BEM and JS

bem
Elio Flores•400
@elioflo
A solution to the Interactive rating component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hello,

Any advice about good practices with javascript? Don't know if it's okay how I used javascript in this challenge.

I get advice to improve! Thanks.

Code

Please log in to post a comment

Log in

Community feedback

  • Account deleted

    Hey there! 👋 Here are some suggestions to help improve your code:

    • To not only improve your HTML code but to identify the main content of you page, you will want to wrap your entire component inside the main element.

    More Info:📚

    MDN Main Element

    • Along with the blank alt tag, you also want to include the aria-hidden=“true” to your “ images/illustrations” to fully remove them from assistive technology.

    More Info:📚

    https://www.w3.org/WAI/tutorials/images/

    • The proper way to build this challenge is to create a form and inside of it, the “rating buttons” should be built using an input radio (wrap all of them inside a fieldset), since this will prevent additional buttons from being active at the same time, and it should have a label element attached to it for accessibility.

    More Info:📚

    MDN <input type="radio">

    MDN <fieldset>: The Field Set element

    If you have any questions or need further clarification, feel free to reach out to me.

    Happy Coding!🎄🎁

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord