Vanza Setiaā¢ 27,835
@vanzasetia
Posted
š Hi David!
š Congratulations on finishing this challenge! I have some feedback that will help you improve this solution:
- Accessibility
- All page content should live inside a landmark (
main
,header
,footer
). In this case, you can wrap all the page content withmain
, except the attribution. For your attribution, you can swap thediv
withfooter
. - For any decorative images, each
img
tag should have emptyalt=""
andaria-hidden="true"
attributes to make all web assistive technologies such as screen reader ignore those images. In this case, all images are decorative only. - Use
rem
or sometimesem
unit instead ofpx
. Usingpx
will not allow the users to control the size of the page based on their needs. - Create a custom
:focus-visible
styling to any interactive elements (button
, links,input
,textarea
). This will make the users can navigate this website using keyboard (Tabs
) easily.
- All page content should live inside a landmark (
- Other
- Try to make the website looks closer to the design.
- On mobile view (360px * 640px), the cards have full width. I would recommend adding
padding
on thebody
element to prevent it. - You can use flexbox or grid to make the cards perfectly on the center of the page.
// ā This is what I did, depending on your markup, yours might be different
body {
display: flex;
align-items: center;
justify-content: center;
min-height: 100vh;
}
- I would recommend using CSS Resets, like Normalize to make everything looks the same (similar) across browsers.
That's it! š„ Keep going and š happy coding!
Marked as helpful
0
P
David Turnerā¢ 4,110
@brodiewebdt
Posted
@vanzasetia Thanks for the tips. I did this one early last year and just started posting them recently. I need to go through the older ones and refactor them. Thanks for the tips, especially the Accessibility ones.
0