@pikapikamart
Posted
Hey, awesome work on this one. Desktop layout look really great, you could make the upper-right-corner background to be a bit bigger. The mobile state looks great as well but if you go to at 390px below, the screen starts to hide the content and creates a horizontal scrollbar.
Here are some other suggestions for the site:
- For the site-logo, remove the word
logo
from it since you don't want to include words that relates tographic
such aslogo
when usingalt
attribute. - On the phone-section, the pattern
background-image
is only decorative so use thealt=""
on it. Usually, when you usearia-hidden="true"
on animg
, you use an empty value for thealt
attribute. - For the phone image, I think you can add a descriptive
alt
value for it , it could be something likealt="equalizer app running on mobile"
.
FOOTER
- Same as well for the site-logo, remove the
logo
word from it. - For the social-media links, remove the word
link
from each of thea
tag since screen-reader will already announce that it is a link, so use only the social-media's name on it. - Adding an extra
aria-hidden="true"
on theimg
tag for each social media so that it will be totally ignored by screen-reader.
Aside from those, great job again on this one.
Marked as helpful
@brodiewebdt
Posted
@martpika Thanks for the tips. I tried to make the background match the Figma file. Still learning how to lay those out. I couldn't get the colored background to co-operate at all.