@FluffyKas
Posted
Hey, your solution actually looks good but I think you're overcomplicating it a bit ^^
-
Your font-family doesn't work at the moment. The easiest way is always just to follow the link given in the style-guide and import the appropriate families and weights to your css/html with the @import/link Google Fonts gives you!
-
The bootstrap approach seems fine, if this helps you, why not! Just make sure you swap your card
div
tomain
and the attributiondiv
tofooter
to make it more semantic. -
Your images are missing their alts. If these are decorative images, you can leave their alts empty, but they still need to be there!
-
I noticed you have a few bits of code that are unnecessary: z-index, top, left. These properties will only work if the element have a
position
on them (anything but static positioning, which is the default). -
For the annual plan section, it can all be solved with flexbox actually, it's just a matter of setting up your html for it. By no means do I think my solution is the very best, but you can take a look at it, hopefully it will be helpful: (https://www.frontendmentor.io/solutions/order-summary-card-with-vanilla-css-qDncfp6V2)
Marked as helpful
@shangum
Posted
Thank you for the feedback @FluffyKas!
I will review the notes you gave and make the suggested changes.
Thanks again
@shangum
Posted
Hey @FluffyKas,
Your solution looks great. Especially how you were able to get the background wave to line up with the card (something I struggled with).
I made the changes you suggested. I also found out that I need to prepend my font folder path with ".." in order for the fonts to be found on github pages. On my local machine they were being loaded.
Thanks again for the advice.