Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS , Flexbox

Jack Smithβ€’ 10

@jacksmith77

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Is there a better, more up to date way to write this code? For the HTML and CSS.

Community feedback

P
Chamuβ€’ 12,970

@ChamuMutezva

Posted

Greetings Jack. Some issues raised in the automated feedback includes

  • a document should have a main landmark . Navigating a web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
  • a site should have the first heading element (h1)
  • the hover effect on the card is scaling way too much in my opinion
0
Anosha Ahmedβ€’ 9,340

@anoshaahmed

Posted

Aim to use semantic tags when writing html. I would change div class="card" to main class="card". I'll also wrap the image in an h1. I see that you wrote two separate codes for the two screen sizes. Instead of that, I would recommend that you write the mobile code as your base code, then make a media query for the bigger size. For example, you can give a max-width to something, and then in the media query for the bigger size, you would just increase the max-width. That way you're building a responsive design but also doing less work

you did great though. that's ^ just a way for u to upgrade ur behind-the-scene skills

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord