Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Html, Css, flexbox

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey Guys, I just finished my first project, and I'd really appreciate any feedback to help me improve my code. I didn't use bootstrap or other tools like that. How can I improve or make my code more advanced...

  • About the divs and the class names on my code?
  • About the way, I have added the icons (and aligned them) to the project?
  • About the overlay... As a newbie, I am open to any other suggestions. Thanks in advance!!!

Community feedback

@maqsudtolipov

Posted

Hi there 👋

Congratulate on finishing your project 🎉. The design looks beautiful 😃.

I will try my best to answer you. About your code, in CSS this code is enough to reset the padding and margin of element because of inheritance, * selector applies to all the elements

*, 
*::before,
*::after {
  margin: 0;
  padding: 0;
  box-sizing: border-box;
}

And also setting font family inside body selector is the best way compared to the others

body { font-family: var(--font-primary); }
  1. Let's about naming classes there is a great technique that is popular among frontend devs called BEM method. I give you a nice cheatsheet to learn more about it click on this 🎁
  2. Adding SVG icons is not recommended, instead use icon packs like ionic ones or google material icons. You just import it like importing CSS or js files. Search some tutorials about it on youtube 👍
  3. About your design its perfect

Happy coding ☕

Marked as helpful

0

@MonicaDalosto

Posted

@maqsudtolipov Thank you for the feedback and the tips! I will study this BEM method and the other icons.

1

@Willearyson

Posted

Mônica não da pra ver o seu site, da erro de página não encontrada.

1

@MonicaDalosto

Posted

@Willearyson Ajustado! Eu troquei o nome do arquivo e não me liguei disso. Obrigada por avisar :)

0

@Willearyson

Posted

@MonicaDalosto particularmente, eu não gosto de usar o github pra criar o site, eu sempre usei o netifly, todos os meu desafios feitos são colocados no ar por esse site, muito simples, só mover a pasta com os arquivos pro site, rápido e simples. :D

0

@MonicaDalosto

Posted

@Willearyson entendi, vou olhar esse netifly e ver se me adapto. Muito obrigada pela dica!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord