Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS, flexbox, no javascript

P
Katrien S 1,070

@graficdoctor

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


This took some time. I was trying to find a way to make it as such, that it would still look good if css failed to load. So I couldn't use hidden. It also took me a while to figure out how to do the desktop-version. I was always bumping into issues with my header. I tried and tried and eventually suddenly had created this. Didn't add javaScript yet, since all tutorials I find on form validation don't fit my 'it has to look good when css fails to load'. Anyways, feedback is nicely appreciated.

Community feedback

P
Grace 27,810

@grace-snow

Posted

Hi Katrien,

I think this solution is pretty nice and love that you're considering how it works with no styles. You might want to consider using some screenreader only text before the icon in your button (instead of aria-label), as that would then show up in your form with styles turned off (at the moment it's only a white icon on a default grey button, so may be a little hard to understand/read)

One thing that's odd with your html structure is a main element nested inside another main. I'd change that to be a div inside main because you've already identified it as the main content of the page.

I think you could simplify this layout quite a bit more by removing all the margin lefts at explicit widths and using some padding on the left column instead with flex or grid properties to acheive the same layout. Positioning things with predefined margins is always going make you have to work harder on your layout and mean you have to change those values at more breakpoints.

Something to consider for next time maybe, coz this works ok as it is.

Well done!

1

P
Katrien S 1,070

@graficdoctor

Posted

@grace-snow This is very valid input. Maybe I will have a go at it again, trying to simplify. I suppose simplifying things would make be a better coder. I hadn't really noticed I'd used main twice. I fixed that now.

1
P
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hey, good job on this challenge, Katrien S! 🙌

Your solution looks pretty good and actually scales quite nicely! 👍

I suggest,

  • Horizontally centering the text in the left side of the page so that it remains in the center of its container even when the screen width increases.
  • Adding a transition to the button element so that there's a nice transition between its regular and active states.

Until you figure out how you'd like to do the JS form validation, the built-in browser form validation works just fine! 😉

Keep coding (and happy coding, too)! 😁

0

P
Katrien S 1,070

@graficdoctor

Posted

@ApplePieGiraffe Cool! I'll take some time to figure out the horizontal centering, in combination with @grace-snow's comment. I did however already add the button transition. Thank you for your feedback :).

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord