Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

html, css, flexbox

cloudpc7•180
@cloudpc7
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


In this solution what I found difficult was how to make it better using less code and create the symantic html that is most simple and basic. I know that this should be an easy challenge so I wanted to make it less code and simpler. I am unsure of the width and the height of the code.

I believe I did a better job this time around. if there is any critiques that need to be made as far as detail I would like to improve. thank you for all the feedback.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted over 1 year ago

    Hello there 👋. Good job on completing the challenge !

    I have other suggestions about your code that might interest you.

    Alt text 📷:

    • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.
    • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

      If you want to learn more about the alt attribute, you can read this article. 📘.

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    Marked as helpful
  • MaximilianoDanielGarcia•1,980
    @MaximilianoDanielGarcia
    Posted over 1 year ago

    Hi @cloudpc7, good job!

    Just 2 little things:

    • If you want to look it centered, you should add this:
    body {
        justify-content: center;
        min-height: 100vh;
    }
    
    • I think the margin top on image should be margin-top: 1.5em;

    If you want to know the exact measurements for the design, you have a figma file in the starter folder.

    I hope these was helpful to you. Regards!

    Marked as helpful
  • Ahlam•300
    @AhlamAb22
    Posted over 1 year ago

    Good start! Here are a few suggestions:

    -Consider using 'justify-content: center;' to center the card on the page.

    -Try to use classes for styling instead of directly styling elements.

    -Implement a CSS reset.

    -Avoid specifying fixed heights and widths; try using 'max-height' and 'max-width' for flexibility.

    Marked as helpful
  • P
    Daniel 🛸•44,830
    @danielmrz-dev
    Posted over 1 year ago

    Hello @cloudpc7!

    Your project looks great!

    I noticed that your card is not completely centered. To place the elemnt in the middle of the page, you can do this:

    • Apply this to the body (in order to work properly, you can't use position or margins):
    body {
        min-height: 100vh;
        display: flex;
        justify-content: center;
        align-items: center;
    }
    

    I hope it helps!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub