@vanzasetia
Posted
π Hi Martha!
πGood job on completing this challenge! This solution looks good on both mobile landscape and portrait mode and so on desktop view too! π
Also, you have done a great job on accessibility part where for decorative images (star icons) you add aria-hidden
and leave the alt
empty. Well done!π
I have some feedbacks on this solution:
- Wrap the
blockquote
content withp
tag.blockquote
elementβs content is a quote, not a chunks of characters. Source: HTML best practice github repo - You can import the
Spartan
font family and all the font weights with only one@import
. - Use
rem
or sometimesem
units for font size. Usingpx
won't allow the users to control the font size based on their needs. - Instead of keep setting different
width
for themain
element, I would recommend to set amax-width
withrem
unit to prevent it from keep getting bigger on bigger screen. - For the testimonial card HTML markup, you already have a good markup. But I would prefer to include everything inside the
figure
element. So, it's up to you, whether you follow the Raymart, me, or leave it as it is.
<figure>
<figcaption> (flex)
<img src="/michael.png" alt="Michael" />
<div>
<p>Michael</p>
<p>Verified</p>
</div>
</figcaption>
<blockquote>
<p>
...quotes
</p>
</blockquote>
</figure>
That's it! Hopefully this is helpful!
Marked as helpful
@Mtc-21
Posted
@vanzasetia Hi, I really appreciate you sharing your knowledge, apply the suggestions.
- I usually use rem in the font-size, I don't understand what happened to me.
- the max-width at the container in rem is great
- I did not know those uses of the figure tag
thank you π