html, css grid and pure javascript

Community feedback

• 

  Jesse Suderman•95

  @C0dras1

  Posted about 5 years ago

  Hey, good job on the implementation! I think there are a quick couple of things that you can improve without too much effort as you already are setup using grid for the layout.

  1. The theme toggle isn't lined up with the dashboards below like in the designs. A quick fix would be place that element on your grid layout and justify to the end so that it aligns with the rest of the content. Also you already have nested grids for each daily card, so make sure to use it to align the social media icons and percent increase values!

  2. In terms of responsiveness I would recommend this article by CSS tricks (https://css-tricks.com/auto-sizing-columns-css-grid-auto-fill-vs-auto-fit/) so that you can fully utilize grid without media queries.

  You're more than welcome to check out my implementation for an example.

  Hope this helps!

  10