Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

HTML, CSS, grid, flex

BlissOnline•50
@BlissOnline
A solution to the Social links profile challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Most proud: -It looks accurate

What would I do different: -After completion I realized I was suppose to include focus state as part of the challenge. I would include it next time

What challenges did you encounter, and how did you overcome them?
  1. Adding padding on one side of a circle shaped element, can ruin the perfect circle shape -In contrast, adding margin on one side of a element, will not affect circle shape
What specific areas of your project would you like help with?

Open to all feedback. I did try to do the last portion, as a grid section, but I failed and fixed it by just using flexbox. I think I'm confused. "grid-template-rows" I managed to get rows. But I'm not sure each element was divided in each row how intended.... As I write this, I'm thinking maybe I had to make all my elements share a class name, I just thought my elements would organize into each created row equal(1 , for each row).... hmmm or maybe I don't understand how to put content in each individual row... I'm not sure...

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Bernardo Poggioni•7,030
    @R3ygoski
    Posted about 1 year ago

    Hello @BlissOnline, congratulations on the project, it turned out really well and almost identical to the proposed design. Well done, it looks great!

    Regarding your question about padding and margin, here's the thing: padding changes how the box will look because it adds internal spacing, pushing the items inside it. On the other hand, margin applies spacing outside the box, meaning it moves away from the external items.

    About your difficulty with the grid, I chose to redo that bottom part (the button section), and it worked correctly for me. Here's what I used:

    .linkContainer {
        display: grid;
        width: 100%;
        height: 15em;
        grid-template-rows: repeat(5, 1fr);
    }
    

    I also noticed that you used some padding: 0% and margin: 0%, but from what I saw, they seemed to have no effect. So, I think it would be best to remove them.

    And a tip about HTML: focus on using more semantic HTML. I noticed that your HTML had many <div> elements, which doesn't affect the structure, but it does affect accessibility a lot. It's always good to have at least one <main>. You could replace your <div class="container"> with a <main> tag.

    If you have any questions, please ask below, and I'll try to help as best as possible.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub