Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

HTML, CSS - Grids and Flexbox

Zach Kyman•220
@zky63
A solution to the Testimonials grid section challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Please let me know if you see any areas of improvement within the code. I messed up by using grid-auto-fill: row so I had to use flexbox to reorder the elements for the mobile version. Will try to fix that some other time.

Thanks!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Lazar Nikolov•260
    @nikolovlazar
    Posted over 4 years ago

    Great job Zach!

    The layout looks pretty much pixel perfect! I can notice that you're missing the card shadows. That would be very easy to fix for you, since you're a Pro user and you have the Figma design file.

    On the other hand, the responsiveness is not perfect. There's a point between the Desktop breakpoint and the Mobile breakpoint where the content is bleeding off the edge. This layout is not simple though, it's a complex layout. What you can do is research the Masonry Grid layout and its responsiveness. It'll give you some ideas on how to refactor your solution and make it responsive.

    Keep up the great work man! Cheers 🙌

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe
    Posted over 4 years ago

    Hey, Zach Kyman! 👋

    Nice work on this challenge! The desktop and mobile layouts of the site look good! 👏

    In addition to lazarnikolov94's helpful feedback, I suggest,

    • Perhaps adding overflow-x: hidden to the body (or something similar) to prevent a horizontal scroll bar from appearing along the bottom of the screen in the desktop layout. 😉

    Keep coding (and happy coding, too)! 😁

    And happy holidays! 🎄

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub