Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

html CSS Javascript

Edeh Sharon•80
@shannychi
A solution to the Dine restaurant website challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


i just finish working on this challenge. tell me what you think about it

Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq
    Posted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HANDLING HERO IMAGE 📸:

    • You need to handle the Hero image with more card because of it's natural shrink to fit behavior.

    • After reviewing your code i have found the way you tackle the design of Hero Section, The issue lies within that.

    • You have created a seperated div homepage-black for texts then the image is separately placed with image tag.

    • We can handle this issue in two ways either controlling the fit of img or refactoring the Hero section.

    • You can simply add object-fit property for the Hero Image, this lets you to tackle natural shrink to fit property of Images (only add this for desktop's with media query)
    .homepage-img {
      object-fit: cover;
      object-position: 90%;
    }
    

    • But i will suggest you to refactor the entire Hero section, by removing the homepage-black and add all of it contents directly to homepage div for image you can simply set the Hero image as background and set it's background-size to cover.

    • After all setting up these things you can simply create the half black block like structure using CSS3's Pseudoselectors, they are ::before and ::after, You can take a minute to go-through this article named ::before / ::after from CSS Tricks site.

    • I haven't still submitted solution for this one because this is a paid one so i can't provide my solution as a reference, But still i can help you with the knowledge i have. Please do ask if any doubts you have regarding your solution.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub