Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 3 years ago

HTML, CSS, JavaScript and API

fetch, sass/scss
Michael Adebambo•1,045
@Blazing-Mike
A solution to the Advice generator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Couldn’t fetch repository

Please log in to post a comment

Log in with GitHub

Community feedback

  • Danilo Blas•6,300
    @Sdann26
    Posted about 3 years ago

    Hi Michael!

    Hi

    Congratulations for finishing the challenge, personally in this type of projects I recommend not to put height so that the box adapts to the size of the text. I would make the following changes, for example:

    To the .container class I would remove the height for both its mobile and desktop size.

    To the image with the class .divider I would give the following margin so that it does not have the button glued.

    margin-top: 2rem;
    margin: 2rem 0 2.8rem 0;
    

    Then you decide if you want to change the spacing in the media querie for mobile.

    Maybe I would give .container more padding on the sides so that it can have more space for the text.

    Leaving aside the design what you should change for the frontend mentor generated report is <div class="wrapper"> to <main class="wrapper"> the idea behind this is that <main> is a semantic and necessary tag that always goes inside the body because it contains the main content of the page.

    Lastly change the h3 to h1, this is mostly because there should always be a h1 per page in your project and in this case it is missing.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub