HTML, CSS, JavaScript

Community feedback

• 

  Rayane•1,935

  @RayaneBengaoui

  Posted about 4 years ago

  Hello Sara,

  Congrats for completing this challenge ! 🙂

  Your solution matches well the design and responses well on screen resizing.

  I would like to suggest :

  • Take a look at semantic HTML tags for better readability. Instead of using elements only, there are plenty of other tags that describe your code better.

  • On tablet view (~940px) the text of the class p-blue-box is smashed on the border. So you could handle it in your media query.

  Overall, well done for the challenge and happy coding ! 😃

  11
• 

  Ameya Deokule•355

  @ameyadeokule

  Posted about 4 years ago

  The mobile view is perfectly done, no complaints there, The only problem I noticed apart from the one mentioned above is the form is positioned relative for reasons I couldn't understand, if possible explain it to me by replying to this comment. I also appreciate the fact that you have used visibility as a toggle value to show errors and nice job on the scroll bar, it is a nice touch. One minor design issue is that your box is a little smaller in dimensions to design so that would come with practice. GOOD JOB and KEEP IT UP!!!

  01