Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS, JavaScript

Sara 180

@saravdberg

Desktop design screenshot for the Intro component with sign-up form coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hey everyone, I'm pretty new to coding, so any feedback is welcome and appreciated!

Community feedback

Rayane 1,935

@RayaneBengaoui

Posted

Hello Sara,

Congrats for completing this challenge ! 🙂

Your solution matches well the design and responses well on screen resizing.

I would like to suggest :

  • Take a look at semantic HTML tags for better readability. Instead of using elements only, there are plenty of other tags that describe your code better.

  • On tablet view (~940px) the text of the class p-blue-box is smashed on the border. So you could handle it in your media query.

Overall, well done for the challenge and happy coding ! 😃

1

Sara 180

@saravdberg

Posted

@RayaneBengaoui Thank you so much for taking the time! I'm going to look into that!

0

@ameyadeokule

Posted

The mobile view is perfectly done, no complaints there, The only problem I noticed apart from the one mentioned above is the form is positioned relative for reasons I couldn't understand, if possible explain it to me by replying to this comment. I also appreciate the fact that you have used visibility as a toggle value to show errors and nice job on the scroll bar, it is a nice touch. One minor design issue is that your box is a little smaller in dimensions to design so that would come with practice. GOOD JOB and KEEP IT UP!!!

0

Sara 180

@saravdberg

Posted

@ameyadeokule Thank you for your feedback! I will look into my usage of relative :)

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord