
Solution retrospective
Thanks in advance for your feedback.
Please log in to post a comment
Log in with GitHubCommunity feedback
- Account deleted
Hey there! 👋 Here are some suggestions to help improve your code:
-
The “star icons” serve no purpose other than to** be decorative;** They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hide them from assistive technology. -
For the profile images
Alt Tag
description, it should never include the following keywords; “image”, “photo”., “picture” and any variation of them. -
To improve the semantics of your component, you want to wrap each individual testimonial component in a
Figure
element, the individuals information should be wrapped in aFigcaption
element and lastly, the testimonial itself should be wrapped in aBlockquote
element.
Code:
<figure> <figcaption></figcaption> <blockquote></blockquote> </figure>
More Info:
- Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
-
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord