html, css, jQuery

Solution retrospective
I've just completed this challenge.
Any suggestions on how I can improve from front-end devs in my network are very welcome. Thanks!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @grace-snow
Looking at the code, there are a few improvements needed
- text can't be in divs, it must always be in a meaningful element
- the toggle is inaccessible at the moment. The label is empty so there is no indication to an assistive technology user which price is shown. (I'll suggest more on correcting this below)
- additionally, some assistive tech won't interact with an input that has height and width of 0, so that should be 1px
- don't forget visible focus states, especially on the toggle but on the links too
With the toggle, I recommend looking up how to build this bit of ui in an inclusive way. For designs like this, where there are two labels and two distinct states where one must always be selected, I will always use radio inputs for that. If this was a simple on/off toggle, on a settings page for example, or when there is only one label, that's when I might use a checkbox, as the meaning maps more closely to checked/unchecked.
Last thing really. Jquery is fine to use if you want to, but it is a huge library to include for such a small task Ans you need to be able to do small dom manipulations like this in vanilla javascript if looking to work professionally in front end at some point. I wouldn't change this, but on your next challenge with js try to do do it without jquery if you can ☺
I hope all this is helpful. Good luck
- @grace-snow
Also, I think you are missing shadows. It's particularly noticeable on the white cards. Designers love us to get these small details right 😉
- @hinlocaesar
Nice Implementation! My feedback Can you check the lines that separate the storage, users? I think opacity should be applied :)
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord