Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

html, css, jQuery

Iryna•110
@Web-Designa
A solution to the Pricing component with toggle challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I've just completed this challenge.

Any suggestions on how I can improve from front-end devs in my network are very welcome. Thanks!

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Grace•32,130
    @grace-snow
    Posted over 4 years ago

    Looking at the code, there are a few improvements needed

    • text can't be in divs, it must always be in a meaningful element
    • the toggle is inaccessible at the moment. The label is empty so there is no indication to an assistive technology user which price is shown. (I'll suggest more on correcting this below)
    • additionally, some assistive tech won't interact with an input that has height and width of 0, so that should be 1px
    • don't forget visible focus states, especially on the toggle but on the links too

    With the toggle, I recommend looking up how to build this bit of ui in an inclusive way. For designs like this, where there are two labels and two distinct states where one must always be selected, I will always use radio inputs for that. If this was a simple on/off toggle, on a settings page for example, or when there is only one label, that's when I might use a checkbox, as the meaning maps more closely to checked/unchecked.

    Last thing really. Jquery is fine to use if you want to, but it is a huge library to include for such a small task Ans you need to be able to do small dom manipulations like this in vanilla javascript if looking to work professionally in front end at some point. I wouldn't change this, but on your next challenge with js try to do do it without jquery if you can ☺

    I hope all this is helpful. Good luck

  • Grace•32,130
    @grace-snow
    Posted over 4 years ago

    Also, I think you are missing shadows. It's particularly noticeable on the white cards. Designers love us to get these small details right 😉

  • Caesar•0
    @hinlocaesar
    Posted over 4 years ago

    Nice Implementation! My feedback Can you check the lines that separate the storage, users? I think opacity should be applied :)

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub