@pikapikamart
Posted
Hey, really great work on this one. Layout in desktop looks really good, responds well and the mobile layout looks good as well.
Some suggestions would be:
- Using
h1
on the topic title of the person's testimonial? blog? I don't know what that is but it is certainly from the person itself. Since in a real website, this would be like a mini component, anh1
on it is not really suited. Maybe anh2
for this one, theh1
would be a screen-reader only text, it will have asr-only
class, you can search up the net for some css stylings of that one, or you could reply in here and I can help and explain it as well :> - The person's name as well the date shouldn't be using
ul
element, since those are not really list items. The person's name should be a heading tag, while the date is justp
tag. - The toggle on the right side should be using
button
element. An interactive component needs to use interactive element. - The
button
as well should have anaria-expanded
attribute on it. This will inform the user if thebutton
has expanded something. The code will look like:
html :
<button aria-expanded="false" aria-label="social media popup" />
javascript:
if ( button is clicked ) {
button.setAttribute("aria-expanded", "true");
} else {
button.setAttribute("aria-expanded", "false");
}
The aria-label
informs the user that this button
is for a popup for the social media.
- Those social media links should be inside their own
a
tag since those are links. The links will be wrapped inside aul
element, since those will be "list" of social media links. - Each
a
tag that wraps the social media should have anaria-label
and the value points to the name of the social media they wrap. For facebooka
tag, it should havearia-label="facebook"
, this way, users will know that this link would take them to facebook. - The
img
being used for the social media should have usedalt=""
andaria-hidden="true"
, since those images are just decoration, you should always hide them by applying those.
Aside from those, really great job on this one. If you have questions about on what I stated, just drop it here and I can help with it.
Marked as helpful
@prajwal18
Posted
@pikamart That was very insightful. Half of the stuff you wrote like aria-label
i have no idea about. I will have to look into it more deeply and write back to you.
Thanks for taking the time to write in so much detail.