Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

HTML, CSS, JS and localStorage

P
Mukarram Haq•440
@MukarramHaq
A solution to the Newsletter sign-up form with success message challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm honestly proud of the desktop design. I feel like its very similar to the original design

The only mistake I made was to make desktop version first which made it really difficult to convert it to mobile version

I didn't do the mobile version as I don't want to spend too much time on it

I now understand why people do mobile first as its easy to expand to a bigger site. I will do that with the next project

What challenges did you encounter, and how did you overcome them?

I was trying to show my email address that I entered in the success page but, it wasn't showing up.

After a lot of digging I found that my script was running before the DOM was loaded

So to overcome that I used DOMContentLoaded to ensure that my DOM loads first and then the script

I used localStorage to store the value from the input field and updated the textContent of the field where the value should go and fetching that value from localStorage

What specific areas of your project would you like help with?

I would like to have just overall feedback about my code and what can be improved

I know I didn't do the mobile version so I would like some feedback without that

Also another thing, I used BouncerJS to validate my email but I couldn't get the error message to be displayed as an inline.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Alex•3,130
    @Alex-Archer-I
    Posted about 1 year ago

    Hi!

    Neat work! I like that you manage to match design almost perfectly. And that's cool that you are practicing such thing like localStorage - it could be very useful =)

    But I need to warn you that in real project it'll be a bit of bad UE if the page have to reload just to show modal window. So, better approach will be to switch display between two windows via JS.

    Error message takes another line for two reasons. At first, it's a block element, so it tends to get all the line width, and second - the parent element of label, input and error message have a display: flex with a flex-directuion: column. To fix it you can put error message into the span inside label and set label to flex.

    <label for="email">A label <span>An error message</span></label>
    

    Or you can wrap label and error in the flexbox.

    Oh, and a couple of semantic tips - you should use main tag for every page, and .benefits element is a list, so it's better to use ul and li here.

    Hope that could help, good luck =)

    P.S. I too began to understand benefits of mobile-first when I started bigger projects. That's one thing which come with exp =)

  • KnightsWatch•170
    @Anni-123-arc
    Posted about 1 year ago

    good!!!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub