HTML, CSS, JS, GRID, Mobile first workflow

Solution retrospective
Experienced developers or other developers who have completed this challenge, can you please test if it meets the design requirements.
I stuck to just the basics, just HTML, and CSS and one grid. I had tough time with images, especially in desktop mode.
This challenge took me more than two weeks and 2 attempts to get this far. Any feedback and any suggestions about code will be deeply appreciated.
Thank you.
Please log in to post a comment
Log in with GitHubCommunity feedback
- @faruqAbdulHakim
First of all, nice work. Congratulations on finishing this challange. 🎉
I want to give some sugesstions that i hope can help you to the next level.
-
I have issues when show site in mobile screen, there is an overflow problem. After trying to resolve that, width and height which is set 100% on html style should be removed. And instead using height 100vh in body style, it should changed to min-height 100vh. (or you can use fixed background-attachment)
-
I suggest to using link
<a>
only when linking to another page or only when redirect to a particular section on the same page -
as in the style guide, font-family need set to Kumbh Sans, sans-serif.
happy coding ^^
Marked as helpful -
- @BikeInMan
P.S: I found some problems with image position after commit. Now it looks much closer the design and better the screenshot.
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord