Tesla_Ambassador• 2,980
@tesla-ambassador
Posted
Hey, this is some really awesome work! Good job on submitting this! I just have a few things to point out:
- If you are going to use JavaScript to validate your email, you shouldn't add required to your email input because the default error message prevents us from seeing your error message since it's displayed on top of it.
- I noticed some space between the hero image and the right margin and incase you want to fix that, consider just using display flex on the parent container and then in order to push it to the margin it's self, set the justify-content property to space between and it then pushes both containers to the edges of their respective margins. I like that you don't have any accessibility issues and HTML issues, Kudos! Keep up the good work and keep on coding!
0
Prajwal Gautam• 190
@prajwal18
Posted
@tesla-ambassador <input required> i had thought about that but was unsure. So Thanks for clearing that up
0
