Skip to content
Submitted over 3 years ago

HTML CSS JS

Prajwal Gautam•190
@prajwal18
A solution to the Base Apparel coming soon page challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Can someone review my work and give feedback, best practices, how you would do certain aspects differently. Any feedback would be highly appreciated.

Code

Please log in to post a comment

Log in

Community feedback

  • Tesla_Ambassador•3,070
    @tesla-ambassador

    Hey, this is some really awesome work! Good job on submitting this! I just have a few things to point out:

    1. If you are going to use JavaScript to validate your email, you shouldn't add required to your email input because the default error message prevents us from seeing your error message since it's displayed on top of it.
    2. I noticed some space between the hero image and the right margin and incase you want to fix that, consider just using display flex on the parent container and then in order to push it to the margin it's self, set the justify-content property to space between and it then pushes both containers to the edges of their respective margins. I like that you don't have any accessibility issues and HTML issues, Kudos! Keep up the good work and keep on coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord