html, css

Community feedback

• 

  szam•800

  @k-stopczynska

  Posted almost 3 years ago

  Hi!

  congratulations on completing the challenge:) Looks really good, but you could improve it by simple modifications:

  For mobile devices set a min-height: 100vh to the body, that would simplify your code and prevent cutting the container right off.

  I see you set the border-radius for mobile, but you chose the wrong element (divs first child is an image). Add some id to your divs in main, it would be easier to point at them this way. Or use main: first child and it would point to the right element.

  On hover states on buttons, as far as I remember, shouldn't be any border set. So, either you set it to none, or keep the border the same color as background or transparent.

  I don't know if you have noticed but your sedans section always starts higher than others in desktops. That's because it's longer and you set margin-bottom the same for every section. Maybe it would be better to fix it just using margin-top.

  Are you really certain you want attribution on top on mobile?

  Happy coding!

  00