Looking to hire developers?
It' s hard to understand why my "img element" at the top (mobile version) has a bottom margin and is a bit separated from the main element. When i tried to inspect the element, the box model does not show a margin bellow header...
what could be happening so?
Id like to know as well, if i should create media queries separately, at the end of the css, or if i can create them below the elements they're changing through the code.
THx a lot
@dottereldesign
Posted
Hey Jeanco, add 'display:block;' to '.img-mobile'. It's actually quite a common question! All images will have this unless you apply a CSS reset. Google Andy Bell's reset for the most popular one to use. Also, don't forget to leave a link to your website in the About section of the projects GitHub page. Best of luck!
Marked as helpful
@engsofjvolfe
Posted
@dottereldesign There's a new thing i have learned. Thx a lot bro..
@correlucas
Posted
👾Hello Jeanco Volfe, Congratulations on completing this challenge!
Your solution its almost done and I’ve some tips to help you to improve it:
1.Add the website favicon inserting the svg image inside the <head>.
<link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">
2.You need to include the title of your PAGE. Do that inserting in the <head> the tag <title> → <title>Product Preview Component - Front End Mentor</title>
3.Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.
Check the link for the official documentation for <picture> in W3 SCHOOLS:
https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture>
<source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
<img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>
👨💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1
✌️ I hope this helps you and happy coding!
Marked as helpful
@engsofjvolfe
Posted
@correlucas Hey Lucas, now that u adviced, i remember when i was studying(the beggining) and i knew this tag picture, but didn't remember while practicing in this project. I appreciate it and surely i'll try to implement this way.
Thx for the tip, extremely valuable for a begginer like me.
BTW, the link doesn't open (404).
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
