Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 2 years ago

HTML, CSS, Responsive

LucasNMtz•690
@LucasNMtz
A solution to the Stats preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


In the mobile version, both the div-img-container and the div-filter become larger than the img and this makes the filter appear overflowing, I tried giving height: 100%; but the img doesn't fit the size either. Why is this happening? How can I solve that?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Abdul Khaliq 🚀•72,380
    @0xabdulkhaliq
    Posted almost 2 years ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    CSS 🎨:

    • Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using margin or padding.

    • We don't need to use margin and padding to center the component both horizontally & vertically. Because using margin or padding will not dynamical centers our component at all states

    • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

    • For this demonstration we use css Grid to center the component.
    body {
        min-height: 100vh;
        display: grid;
        place-items: center;
    }
    
    • Now remove these styles, after removing you can able to see the changes
    main {
      margin: 6% auto 5%
    }
    


    • Now your component has been properly centered, my additional suggestion would be to using relative units like em, rem for width of main instead of using percentage(%)

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
  • danemaas•520
    @danemaas
    Posted almost 2 years ago

    Hi, Great work in finishing this challenge!! To your question, I think the problem lies with your main tag.. you set your main tag's width to a percentage. using a percentage in width will stretch your container as the screen gets bigger.. so if you want it to be at fixed size. you should consider using a fixed size also.. I would suggest using the 375px for the max-width for mobile.. then for wider screens you can use 567px or 768px so it would not stretch so much. Hope this will help fixing your problem. Happy Coding!!

    Marked as helpful
  • hitmorecode•7,540
    @hitmorecode
    Posted almost 2 years ago

    Nice well done. I opened your page in Firefox and everything seems fine even in mobile screen size. I do have some tips

    • Make it a habit adding min-height: 100vh; on the body and use flexbox or grid to place the card in the middle of the page. If you do this you can remove margin on main
    • As for the image overlay add mix-blend-mode: multiply; and set the hsla alpha channel to 0.8. This will match the overlay on the design file.
    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub