Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

HTML | CSS | Responsive Design | Custom Properties

Daniel•130
@tenczowy
A solution to the 3-column preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I am honing my skills in writing clean and maintainable HTML and CSS code, so any feedback on how I can improve to make my code easier to work with for other developers is welcome. My goal is to one day present myself as an experienced web developer who is proficient in the fundamentals and capable of working collaboratively within a team.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Petrit Nuredini•2,860
    @petritnuredini
    Posted over 1 year ago

    Congratulations on completing your project! It's fantastic to see your hard work come to life. Here are some best practices and recommendations to consider for further improvements:

    1. Semantic HTML:

      • Use semantic tags where applicable. Instead of div for every element, use main, section, article, header, footer, etc., to improve readability and SEO.
      • For example, replace <div class="wrapper"> with <main class="wrapper">.
    2. CSS Best Practices:

      • Organize your CSS properties: Group related properties together, for instance, put all flexbox-related properties in one group.
      • Consistent Naming Convention: Stick to a consistent naming convention like BEM, which can make your classes more readable and maintainable.
    3. Responsive Design:

      • Consider using media queries for different screen sizes. Ensure that your cards stack vertically on smaller screens for better mobile experience.
      • Example:
        @media (max-width: 768px) {
          .wrapper {
            flex-direction: column;
          }
        }
        
    4. Accessibility:

      • Alt text for images: Ensure all images have descriptive alt text for accessibility. Good to see you've already started doing this!
      • Keyboard navigation: Ensure that the site can be navigated using a keyboard, especially the buttons and links.
    5. Performance:

      • Optimize images to reduce load times, consider using modern formats like WebP.
      • Minify CSS and JavaScript files for production.
    6. Code Maintainability:

      • Comments: Add comments to your CSS and HTML files to describe sections or complex parts.
      • Modular CSS: Consider splitting your CSS into separate files for each component for easier management.
    7. Learning Resources:

      • For semantic HTML: MDN Web Docs
      • For CSS best practices: CSS Guidelines
      • Responsive design tips: Responsive Web Design
      • Accessibility guidelines: Web Accessibility Initiative

    Keep up the great work! Your journey in web development is off to a strong start. Remember, each project is a stepping stone to becoming a more skilled developer. Looking forward to seeing your future projects! 💪🚀

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SASS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub