@dusanlukic404
Posted
Hi Mahmoud! I really like your solution. There is no issues - GREAT!!!
I recommend you to use 3rem for margin-top and margin-bottom instead of 10rem because it should be landing page so you don't need vertical scrollbar. Also, when you change that set overflow: hidden; to your body element.
- (If you change things like I said also do this)
- In your media query for mobile devices you can add margin-top and bottom.
Marked as helpful
@Mahmoud-Elshaer-10
Posted
@dusanlukic404 Thank you so much for your feedback. I already changed the margin from 10rem to 3rem, but can you explain why I need to set overflow: hidden; to the body element.
@dusanlukic404
Posted
@Mahmoud-Elshaer-10 when you set it you won't have that vertical scrollbar. On normal sites you need them but this is a landing page so it is unnecessary. Take a look at my project if you want to 😀
