Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

HTML, CSS, Vanilla JS Validation

accessibility, react, sass/scss, bootstrap
Gilang Aditya•425
@madegilangaditya
A solution to the Interactive card details form challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Any feedback reagarding the design or the javascript code will be very appreciated

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Assurance Chioma Ikogwe•410
    @Aik-202
    Posted almost 3 years ago

    Hi, Gilang Nice one!!!. The responsiveness is on point, and your design is really nice, putting a bit of box shadow on the cards was a really great idea!!. But I have some suggestions

    1. If the cursor is still on any input field and the confirm button is clicked , it doesn't work. Don't know y, maybe check your JavaScript

    2. Try setting the height of the image to 100vh so that it takes the total height of the viewpoint.

    3. You can use max-length attributes in your html to ensure that the user only enters 3 CVC numbers, 19 card numbers, 2 numbers for the month and year as well...

    4. I also noticed that there's no validation taking place for the card name field, the users are allowed to enter just anything. That is For the card name, only letters should be allowed and vice versa.

    5. For the month field the user should only be allowed to enter numbers 1 to 12 as there are only 12 months, you can do a check for that.

    6. The error Message for the Year field is overlapping that for the Month, try positioning them well.

    7.) It will also be nice if when the user clicks confirm and there's any input field left blank, an error message will tell them that...

    Hope this helps....

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub