Html ;css;js

Community feedback

• 

  Majid Mohammed•90

  @majid-tech

  Posted 4 months ago

  You've done a great job on this project! I have a couple of suggestions that could further improve your code:

  1. Error Message Placement:

     • On lines 21 and 22, the error message could be wrapped in a <span> element inside the <label> tag. This would help keep the error message aligned with the label using float: right;, ensuring that all elements stay on the same line.
     • Currently, because a <p> tag is used, the error message pushes the input[type="email"] field downward when rendered.
     • Here's an improved approach:

     <label for="email" class="label">
         Email address <span id="error-message"></span>
     </label>
     

     #error-message {
         color: red;
         font-size: 14px;
         float: right; /* Aligns the error message with the label */
         display: none; /* Initially hidden */
     }
     

  2. Responsiveness:

     • The desktop view looks great! However, I recommend improving the responsiveness of the page. When viewed on smaller screens, some elements don't adjust properly to the screen size.
     • You could use flexbox, CSS grid, combined with the media query to ensure a smooth experience across different devices.

  Overall, great work! Keep it up! 🚀

  00