HTML e CSS

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  CSS 🎨:

  • Let me explain, How you can easily center the component for better layout without usage of absolute positioning.

  ---

  • We don't need to use absolute to center the component both horizontally & vertically. Because using absolute will not dynamical centers our component at all states

  ---

  • To properly center the component in the page, you should use Flexbox or Grid layout. You can read more about centering in CSS here 📚.

  ---

  • For this demonstration we use css Grid to center the component

  body {
  min-height: 100vh;
  display: grid;
  place-items: center;
  }
  

  • Now remove these styles, after removing you can able to see the changes

  div {
  position: absolute;
  top: 25%;
  left: 42%;
  margin: -25px -25px;
  }
  

  ---

  • Now your component has been properly centered.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  01

  Marked as helpful
• 

  amrajat•170

  @amrajat

  Posted about 2 years ago

  Congratulation on submitting the challenge. I have a few suggestions please consider refactoring its code if you find it useful.

  • You can align this component horizontally and vertically by multiple hacks such as margins, display: flex + justify-content: center + align-items: center, or by display: grid, place-items: center.

  • you should have a minimum of one h1 heading per page for accessibility.

  happy coding :)

  01

  Marked as helpful