Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Html for the makeup, css for custom styling, Bootstrap, and JavaScript

#bootstrap

@Yunishello

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Abdul 8,560

@Samadeen

Posted

Hey!! Cheers 🥂 on completing this challenge.. .

Lets firstly work on your accessibility issues.

  • Document should have on main landmark basically means your html should be structured more semantically and the correct format should be your <header>......</header> followed by your <main>......</main> and lastly your <footer>....</footer> hence you should use <main class="row"> instead of <div class="row">.
  • Your footer should be <footer class="attribution"> instead of <div class="attribution">.
  • Page should contain a level-one heading basically means your html should have a h1 it aid navigation hence <p class="qoute"> "Please click the button below to get an advice." </p> should be <h1 class="qoute"> "Please click the button below to get an advice." </h1> and you should also go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

This should fix most of your accessibility issues.

. Regardless you did amazing... hope you find this helpful... Happy coding!!!

0

@Yunishello

Posted

@Samadeen, thanks for your comment I will work on that and give you a feedback. I do appreciate 😊

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord