Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

HTML, Sass and JavaScript. I added a few extra features too!

Tesla_Ambassador•3,070
@tesla-ambassador
A solution to the Calculator app challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Hey, guys, this is my first app and I added some scientific methods to it like sin, cos...etc.. It's functionality is pretty good but it still has some flaws, I hope you can look into my code and advise me on how to make it better! Your feedback will be very much appreciated.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe
    Posted over 3 years ago

    Hey, Kevin! 👋

    It's so good to see you complete another challenge! 😀 You've done a nice job on this one and I love the ideas you had for the extra features you added! 🤩

    A few small tips to improve the design of your solution would be,

    • Using the font specified in the style guide for this challenge for a few of the text elements on the page (such as the text in the calculator screen and the word "Calc" in the upper-left corner of the calculator).
    • Adding hover and active states to the calculator buttons. This will be a small touch that's probably quite easy to add but will make a big difference in the UX, I think! A simple background color change for the hover state and a subtle transform or something for the active state should do it.
    • This isn't a tip but I really like your attribution for this solution! 😉

    Also... it might be worth taking another look at the functionality of the scientific side of the calculator. There are a few quirks such as not being able to add/subtract/etc. with "π" and not being able to delete items like "sin" or "tan". But for your first submission of this challenge, I think this is very cool! 😎

    You've really improved and it's made me happy to see your progress! Keep it up! 🎉

    And don't forget—keep coding (and happy coding, too)! 😄

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub