Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, SCSS, JS

Grady 80

@grady2002

Desktop design screenshot for the Article preview component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Please help correct my mistakes if any

Community feedback

@mesutcifci

Posted

Hi Grady Congrats!

Everything looks good.

  • you can add cursor : pointer property to social media icons.

  • may be you can reduce font-size in mobile view.

  • you should give meaningful class names to html elements. c1 and c2 are not good.

  • if you use it the right way html5 semantic tags are good. I think you used the footer element in the wrong place.

  • instead of placing it under the body, if you want you can place script tag to head section with ```defer```` attribute. If you dont know what is defer just google it.

  • nesting css selectors like this .container .c2 .shift is not best practice. You should avoid this beacuse such use makes it difficult to read code and causes performance problems.

1

Grady 80

@grady2002

Posted

@mesutcifci thank you so much for the review, i will surely improve more and learn from my past errors

Thank you for your precious time

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord