Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 3 months ago

QR-Code Component using HTML, CSS, and Vercel Deployment

accessibility
Abdelrahman Emara•10
@AAEmara
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I'm proud of using CSS Variables and using Semantic HTML, where I brokedown the design into different <div> tags, to control styling the different HTML elements. This helped me to overcome my fears.

What challenges did you encounter, and how did you overcome them?

I had a little challenge of putting the QR-Code component in the middle of the body element.

I managed to overcome this, by using Flexbox and the flex-direction property was set with the column value, and finally, applied the justify-content and align-items properties to be at center.

What specific areas of your project would you like help with?

I would like to know if there was a better way to structure my HTML code, and if any header level would be used for the first sentence used in the QR-code component.

Also, I used CSS Variables and tried my best in styling the component, but I feel there always could be better. Are there any guides or rules to follow that I've missed in my approach to style the HTML elements? Could they be less verbose, if applicable?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • João Vitor•720
    @jvssvj
    Posted 3 months ago

    Hi friend, great solution 👏. To improve your HTML you could use semantic tags. For example, in your card you could use a main tag, in the header-content div you could use a section and eliminate the header-rectangle div, since it is not necessary. In the attribution div you could use a footer, since it is the page footer. Another tip is not to use fixed width (in some cases) in this case, you could use a maximum width, for example:

    .component {
      width: 100%;
      max-width: 500px; //as needed
    }
    

    This is for screens smaller than 375px. Use whenever necessary for your website to adjust to different screens.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit 1st-party linked stylesheets, and styles within <style> tags.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub