Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 3 years ago

HTML semântico, CSS, Java Script iniciante

animation, styled-components
Pedro Henrique Florêncio Telles•30
@PedroHTelles
A solution to the Interactive rating component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


Venho aprendendo JS a mais ou menos uma semana, e tive uma dificuldade inesperada para conseguir recuperar o valor dos <input type="radio"> neste desafio. Gostaria de saber se a forma com que resolvi este desafio pode presentar algum problema ou vai contra alguma "boa pratica" da profissão. Qualquer outro feedback também será muito bem vindo. Obrigados a todos da comunidade !

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Rodrigo Pires•410
    @rodrigompires
    Posted almost 3 years ago

    Olá Pedro. Parabéns pela solução. Bom trabalho. Quanto a sua pergunta, como você mesmo diz que está bem no inicio dos estudos de JS, você ainda não viu muitas coisas que facilitam e são melhores a utilizar. Um bom exemplo é que você poderia utilizar um laço de repetição, como o For ou melhor ainda o método nativo ForEach.

    Por exemplo:

    suaArray.forEach(elemento => { elemento.addEventListener('click', nome_função) });

    ou

    for (let i = 0; i < suaArray.length; i++) { suaArray[i].addEventListener("click", nome_função); }

    Outro ponto é, não é uma boa prática declarar variáveis com VAR por questões de escopo, bugs que podem ocorrer e etc. Na maioria dos casos você usará CONST ou LET, ou seja:

    VAR - Evite usar ao máximo. LET - Quando a variável precisa ter seu valor alterado. CONST - Utilize SEMPRE que possível.

    Marked as helpful
  • Leonardo Hernandes•70
    @leonardohernandesq
    Posted almost 3 years ago

    Cara, realmente esse monte de if e else poderia causar problemas em um código muito grande.

    um jeito mais fácil que encontrei para pegar esse valor é

    x = document.querySelector(#form).name-do-seu-radio.value

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub