IRVINE MESA• 1,855
@DrMESAZIM
Posted
hi.. great work..I think you should align the footer to the center of the page
1
Dao Dinh Tu• 10
@songavt
Posted
@DrMESAZIM thank you. I will do again
0
Design comparison
Solution retrospective
Newbie
Community feedback
Cường• 845
@docuong0912
Posted
look good for a beginner, good job
1
Dao Dinh Tu• 10
@songavt
Posted
@docuong0912 thanks, teacher :))
0
Fraser Watt• 1,790
@fraserwat
Posted
-
In terms of best practice, I would split your CSS out into a separate file. This article shows you how to do this in the "External Style Sheets" heading - https://www.tutorialrepublic.com/css-tutorial/css-get-started.php
-
Instead of having the background images in their own div, have you tried setting them as
background-imageproperties of the body? This should also fix the problem of your footer (.attributionclass) being outside of the background area. -
Use margin to position the profile picture instead of absolute position, as this is causing it to be slightly off center.
It's a good start though, took me ages to work out the background stuff! 👍
0
Basieem• 0
@fabsway23
Posted
make it responsive
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord